Added property getter/setters for voltage and throttle. - #19
Merged
Conversation
zachwaffle4
requested changes
Jul 28, 2026
| * This is the simplest control mode: power is applied directly. | ||
| */ | ||
| var throttle: Double | ||
| get() = when (val mode = controlType) { |
Collaborator
There was a problem hiding this comment.
I would simply have it return power.
| fun setThrottle(throttle: Double) { | ||
| controlType = ControlType.Throttle(throttle) | ||
| } | ||
| val voltage: VoltageMeasure |
Collaborator
There was a problem hiding this comment.
Make this a var and have the set function set controlType like what you did for throttle.
zachwaffle4
approved these changes
Jul 28, 2026
Author
|
Do you want me update my fork and then do the things? I see that there is already a commit before mine, meaning that my fork is outdated. |
…setVoltageSetpoint().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added property getter/setters for voltage and throttle. Also replaced
setVoltage()withsetVoltageSetpoint()